Add lint to detect usage of invalid atomic ordering #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-veerareddy
force-pushed
the
issue-4679-atomic-ordering
branch
from
c4d034f
to
c3ad468
Compare
phansch
suggested changes
Jan 6, 2020
flip1995
added
the
S-waiting-on-author
Detect usage of invalid atomic ordering modes such as
`Ordering::{Release, AcqRel}` in atomic loads and
`Ordering::{Acquire, AcqRel}` in atomic stores.
krishna-veerareddy
force-pushed
the
issue-4679-atomic-ordering
branch
from
464f4b2
to
e5aa9d1
Compare
krishna-veerareddy
force-pushed
the
issue-4679-atomic-ordering
branch
from
e5aa9d1
to
fe21ef4
Compare
phansch
approved these changes
Jan 7, 2020
|
@bors r+ thanks! |
|
📌 Commit fe21ef4 has been approved by |
phansch
removed
the
S-waiting-on-author
bors
added a commit
that referenced
this pull request
Jan 7, 2020
…r=phansch
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as `Ordering::{Release, AcqRel}` in atomic loads and `Ordering::{Acquire, AcqRel}` in atomic stores.
Fixes #4679
changelog: Add lint [`invalid_atomic_ordering`]
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect usage of invalid atomic ordering modes such as
Ordering::{Release, AcqRel}in atomic loads andOrdering::{Acquire, AcqRel}in atomic stores.Fixes #4679
changelog: Add lint [
invalid_atomic_ordering]